[TCGC] Fix naming logic for anonymous model wrapped by HttpPart
#1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
commented
Sep 6, 2024
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
msyyc
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
packages/typespec-client-generator-core/test/types/multipart-types.test.ts
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Sep 6, 2024
chunyu3
approved these changes
Sep 9, 2024
iscai-msft
reviewed
Sep 10, 2024
Bumps [core](https://github.com/microsoft/typespec) from `0be9e8f` to `a5fc2ce`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/typespec/commit/a5fc2ce6201098d1d7095bb4e7a6109c1dd2fe9a"><code>a5fc2ce</code></a> Customization fixes (<a href="https://github.com/microsoft/typespec/issues/4385">#4385</a>)</li> <li><a href="https://github.com/microsoft/typespec/commit/2010bc4490ab84a18bf3af5ab5c77863e87d9853"><code>2010bc4</code></a> http-client-java, compiler 0.46 (<a href="https://github.com/microsoft/typespec/issues/4393">#4393</a>)</li> <li>See full diff in <a href="https://github.com/microsoft/typespec/compare/0be9e8f22bb587db69bf1fc5e73effef1e2364a5...a5fc2ce6201098d1d7095bb4e7a6109c1dd2fe9a">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/e2e-tests/cadl-ranch-specs (#1517) Bumps [@azure-tools/cadl-ranch-specs](https://github.com/Azure/cadl-ranch) from 0.37.1 to 0.37.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Azure/cadl-ranch/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is blocking a new RP [kubernetesruntime](https://github.com/Azure/azure-rest-api-specs/blob/f5321f9b29083f9ea4c028e7484504875e04a758/specification/kubernetesruntime/KubernetesRuntime.Management/storageclass.tsp#L273) generating SDK.
msyyc
commented
Sep 12, 2024
packages/typespec-client-generator-core/test/types/multipart-types.test.ts
Show resolved
Hide resolved
iscai-msft
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Looks good! Do you want to release this before next month's release or can it wait until next month's release. If you want to release it before, we've started using a release branch https://github.com/Azure/typespec-azure/blob/main/CONTRIBUTING.md#make-a-patch-release
auto-merge was automatically disabled
September 13, 2024 02:49
Merge commits are not allowed on this repository
Other languages hope we could release a patch version asap so I will merge this into release branch |
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Sep 24, 2024
…ure#1491) fix Azure#1483 The PR contains: - Bug fix for empty name of anonymous model wrapped by `HttpPart` - add `afterEach` in test to make sure the `sdkPackage.models/enums` must have non-empty name. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wei Hu <[email protected]>
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Sep 26, 2024
…ure#1491) fix Azure#1483 The PR contains: - Bug fix for empty name of anonymous model wrapped by `HttpPart` - add `afterEach` in test to make sure the `sdkPackage.models/enums` must have non-empty name. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wei Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1483
The PR contains:
HttpPartafterEachin test to make sure thesdkPackage.models/enumsmust have non-empty name.